Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 1612273002: Don't force display:table-cell and float:none on table cell elements when in quirks mode (Closed)

Created:
4 years, 11 months ago by nainar
Modified:
4 years, 11 months ago
Reviewers:
rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't force display:table-cell and float:none on table cell elements when in quirks mode Currently in quirks mode we force table cell elements to display:table-cell and float:none. This current action is not supported in quirks spec and is inconsistent with Gecko. This leads to elements with display/float set to lose that information. This patch fixes that and allows those elements with display/float to retain this state even in quirks mode. BUG=580053 Committed: https://crrev.com/95773a85549dc14dbb42d665dadd7875d05df0a1 Cr-Commit-Position: refs/heads/master@{#370904}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M third_party/WebKit/LayoutTests/fast/table/floating-th.html View 1 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/table/quirks-mode-ignore-display-inline-table.html View 1 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
nainar
@rune, PTAL? Thanks! This is a follow up from crbug.com/369979
4 years, 11 months ago (2016-01-22 00:46:43 UTC) #3
rune
lgtm with nit https://codereview.chromium.org/1612273002/diff/1/third_party/WebKit/LayoutTests/fast/table/quirks-mode-ignore-display-inline-table.html File third_party/WebKit/LayoutTests/fast/table/quirks-mode-ignore-display-inline-table.html (right): https://codereview.chromium.org/1612273002/diff/1/third_party/WebKit/LayoutTests/fast/table/quirks-mode-ignore-display-inline-table.html#newcode7 third_party/WebKit/LayoutTests/fast/table/quirks-mode-ignore-display-inline-table.html:7: <td id="td1" style="display:block; float:left" ></td> Nit: ...
4 years, 11 months ago (2016-01-22 01:21:09 UTC) #4
nainar
Also changed a failing LayoutTest. Removed float on td element to avoid rebaselining as was ...
4 years, 11 months ago (2016-01-22 02:01:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612273002/20001
4 years, 11 months ago (2016-01-22 02:44:13 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-22 04:34:57 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 04:37:31 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/95773a85549dc14dbb42d665dadd7875d05df0a1
Cr-Commit-Position: refs/heads/master@{#370904}

Powered by Google App Engine
This is Rietveld 408576698