chrome/browser/extensions/component_migration_helper.cc - Issue 1612203002: [Media Router] Adds a contextual menu item to remove the MR component action.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/component_migration_helper.cc

Issue 1612203002: [Media Router] Adds a contextual menu item to remove the MR component action. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to pkasting@ comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/component_migration_helper.h ('k') | chrome/browser/extensions/component_migration_helper_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/component_migration_helper.cc

diff --git a/chrome/browser/extensions/component_migration_helper.cc b/chrome/browser/extensions/component_migration_helper.cc

index e2baca13ab7adfe7c1b42d7a85ee53fe22a29593..389959a3f5b2b3fe5fcc4ca908fa278983b7c37f 100644

--- a/chrome/browser/extensions/component_migration_helper.cc

+++ b/chrome/browser/extensions/component_migration_helper.cc

@@ -113,6 +113,16 @@ void ComponentMigrationHelper::OnFeatureDisabled(

delegate_->RemoveComponentAction(component_action_id);

}

+void ComponentMigrationHelper::OnActionRemoved(

+ const std::string& component_action_id) {

+ // Record preference for the future.

+ SetComponentActionPref(component_action_id, false);

+ // Remove the action.

+ if (delegate_->HasComponentAction(component_action_id))

+ delegate_->RemoveComponentAction(component_action_id);

void ComponentMigrationHelper::OnExtensionReady(

content::BrowserContext* browser_context,

const Extension* extension) {