Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1612113003: Rename CPDF_PageObjects to CPDF_PageObjectList (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Oliver Chang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Rename CPDF_PageObjects to CPDF_PageObjectList Prefer class names to be singular. R=ochang@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/9ebc84109d7d2f7b81f06f19e5db20888e026c3b

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix stray file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -45 lines) Patch
M core/include/fpdfapi/fpdf_module.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fpdfapi/fpdf_page.h View 3 chunks +5 lines, -5 lines 0 comments Download
M core/include/fpdfapi/fpdf_render.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/include/fpdftext/fpdf_text.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page.cpp View 5 chunks +10 lines, -10 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/pageint.h View 4 chunks +4 lines, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/render_int.h View 2 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdftext/fpdf_text_search.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdftext/text_int.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/fxedit/fx_edit.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Edit.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_pageobjs.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Edit.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tom Sepez
Oliver, cosmetic change, nothing but sed.
4 years, 11 months ago (2016-01-21 23:47:42 UTC) #2
Oliver Chang
https://codereview.chromium.org/1612113003/diff/1/fpdfsdk/src/fpdf_flatten.cpp File fpdfsdk/src/fpdf_flatten.cpp (right): https://codereview.chromium.org/1612113003/diff/1/fpdfsdk/src/fpdf_flatten.cpp#newcode45 fpdfsdk/src/fpdf_flatten.cpp:45: for (const auto& pPageObject : *pPDFPage) { premature change?
4 years, 11 months ago (2016-01-21 23:58:46 UTC) #3
Oliver Chang
oh wait, you removed it. lgtm
4 years, 11 months ago (2016-01-21 23:59:00 UTC) #4
Tom Sepez
On 2016/01/21 23:59:00, Oliver Chang wrote: > oh wait, you removed it. lgtm Yeah, I ...
4 years, 11 months ago (2016-01-22 00:00:13 UTC) #5
Tom Sepez
4 years, 11 months ago (2016-01-22 00:01:46 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
9ebc84109d7d2f7b81f06f19e5db20888e026c3b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698