Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 16121002: Linux: make it possible to undo changes made by replace_gyp_files.py (Closed)

Created:
7 years, 7 months ago by Paweł Hajdan Jr.
Modified:
7 years, 6 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -7 lines) Patch
M build/linux/unbundle/replace_gyp_files.py View 2 chunks +25 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Paweł Hajdan Jr.
7 years, 7 months ago (2013-05-28 03:40:42 UTC) #1
Ryan Sleevi
From that thread, is this actually needed?
7 years, 6 months ago (2013-05-28 17:43:11 UTC) #2
Paweł Hajdan Jr.
On 2013/05/28 17:43:11, Ryan Sleevi wrote: > From that thread, is this actually needed? Yes. ...
7 years, 6 months ago (2013-05-28 17:52:56 UTC) #3
Ryan Sleevi
Well, please realize I don't have Python readability - so you'll want a different reviewer.
7 years, 6 months ago (2013-05-28 17:54:24 UTC) #4
Paweł Hajdan Jr.
Marc-Antoine, could you take a look?
7 years, 6 months ago (2013-05-28 18:05:57 UTC) #5
M-A Ruel
On 2013/05/28 17:54:24, Ryan Sleevi wrote: > Well, please realize I don't have Python readability ...
7 years, 6 months ago (2013-05-28 18:09:47 UTC) #6
Paweł Hajdan Jr.
7 years, 6 months ago (2013-05-28 18:54:30 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r202616 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698