Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 1612093003: workers: Move where idle-tasks are turned on for v8::Isolate. (Closed)

Created:
4 years, 11 months ago by sadrul
Modified:
4 years, 11 months ago
Reviewers:
kinuko
CC:
chromium-reviews, blink-reviews, kinuko+worker_chromium.org, falken, blink-worker-reviews_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

workers: Move where idle-tasks are turned on for v8::Isolate. Compositor-workers currently do not support idle tasks (and so does not have idle-task-runner). So idle-tasks should not be turned on for the compositor workers' isolate. To fix this, move the code that turns on idle tasks for the isolate into WorkerThread::initializeIsolate(), so that compositor worker can choose to not do this for now. BUG=565789, 430155 Committed: https://crrev.com/f77609d9f544961f0158fbff93e52c82e4c9dac2 Cr-Commit-Position: refs/heads/master@{#371656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
sadrul
4 years, 11 months ago (2016-01-21 17:35:41 UTC) #2
sadrul
ping
4 years, 11 months ago (2016-01-26 05:48:26 UTC) #3
kinuko
lgtm
4 years, 11 months ago (2016-01-26 09:15:56 UTC) #4
kinuko
On 2016/01/26 09:15:56, kinuko wrote: > lgtm (sorry for slow review!)
4 years, 11 months ago (2016-01-26 09:16:11 UTC) #5
sadrul
On 2016/01/26 09:16:11, kinuko wrote: > On 2016/01/26 09:15:56, kinuko wrote: > > lgtm > ...
4 years, 11 months ago (2016-01-26 17:17:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612093003/1
4 years, 11 months ago (2016-01-26 17:17:57 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/164504)
4 years, 11 months ago (2016-01-26 20:37:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612093003/1
4 years, 11 months ago (2016-01-26 22:51:24 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 00:21:44 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 00:22:38 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f77609d9f544961f0158fbff93e52c82e4c9dac2
Cr-Commit-Position: refs/heads/master@{#371656}

Powered by Google App Engine
This is Rietveld 408576698