Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1612013002: Revert of [turbofan] optimize spills in defered blocks (Closed)

Created:
4 years, 11 months ago by Jarin
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] optimize spills in defered blocks (patchset #3 id:240001 of https://codereview.chromium.org/1551013002/ ) Reason for revert: Regresses lots of benchmarks: https://crbug.com/579900 Original issue's description: > [turbofan] optimize spills in defered blocks > > Up to now, for ranges spilled in deferred blocks, we would spill every > time a range would switch from using a register to spill slots. That can > be redundant, leading to avoidable code size cost. > > This change addresses this issue, by performing the spills as early as > possible. > > BUG= > > Committed: https://crrev.com/7c54dc33855b8ac31f26b309671f9b5481a74376 > Cr-Commit-Position: refs/heads/master@{#33413} TBR=bmeurer@chromium.org,mtrofin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/7f62e1222df37e0fcbe96d550a1fdcd3499ba37c Cr-Commit-Position: refs/heads/master@{#33431}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -303 lines) Patch
M src/compiler/live-range-separator.cc View 2 chunks +1 line, -5 lines 0 comments Download
M src/compiler/register-allocator.h View 6 chunks +7 lines, -31 lines 0 comments Download
M src/compiler/register-allocator.cc View 11 chunks +214 lines, -267 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jarin
Created Revert of [turbofan] optimize spills in defered blocks
4 years, 11 months ago (2016-01-21 12:06:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612013002/1
4 years, 11 months ago (2016-01-21 12:06:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 12:06:30 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 12:07:07 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f62e1222df37e0fcbe96d550a1fdcd3499ba37c
Cr-Commit-Position: refs/heads/master@{#33431}

Powered by Google App Engine
This is Rietveld 408576698