Rename editableRootElementForPosition() to rootEditableElementOf()

This patch renames |editableRootElementForPosition()| to
|rootEditableElementOf()| to align with |Node::rootEditableElement() and
|VisiblePosition| version of |rootEditableElementOf()|.

BUG=578974
TEST=n/a; no behavior changes

Committed: https://crrev.com/d9a9181fd4f36031b9d02db8b82e1679a77844ea
Cr-Commit-Position: refs/heads/master@{#370679}

[yosin_UTC9, 2016-01-21 09:25:50]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-21 09:26:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1611953002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1611953002/1

[yosin_UTC9, 2016-01-21 09:36:51]

Description was changed from

==========
2016-01-21T18:23:57

BUG=n/a
==========

to

==========
This patch renames |editableRootElementForPosition()| to
|rootEditableElementOf()| to align with |Node::rootEditableElement() and
|VisiblePosition| version of |rootEditableElementOf()|.

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-01-21 09:36:51]

yosin@chromium.org changed reviewers:
+ hajimehoshi@chromium.org, tkent@chromium.org, xiaochengh@chromium.org,
yoichio@chromium.org

[yosin_UTC9, 2016-01-21 09:37:45]

Description was changed from

==========
This patch renames |editableRootElementForPosition()| to
|rootEditableElementOf()| to align with |Node::rootEditableElement() and
|VisiblePosition| version of |rootEditableElementOf()|.

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
This patch renames |editableRootElementForPosition()| to
|rootEditableElementOf()| to align with |Node::rootEditableElement() and
|VisiblePosition| version of |rootEditableElementOf()|.

BUG=578974
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-01-21 09:37:56]

PTAL

[commit-bot: I haz the power, 2016-01-21 11:03:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 11:03:10]

Dry run: This issue passed the CQ dry run.

[tkent, 2016-01-21 13:19:37]

The CQ bit was checked by tkent@chromium.org

[tkent, 2016-01-21 13:19:38]

lgtm

https://codereview.chromium.org/1611953002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/1611953002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:231: ContainerNode*
node = highestRoot->parentNode();
Not related to this CL, but I wonder why we need to scan ancestors of
rootEditableElement.

[commit-bot: I haz the power, 2016-01-21 13:20:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1611953002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1611953002/1

[commit-bot: I haz the power, 2016-01-21 13:24:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-21 13:25:37]

Description was changed from

==========
This patch renames |editableRootElementForPosition()| to
|rootEditableElementOf()| to align with |Node::rootEditableElement() and
|VisiblePosition| version of |rootEditableElementOf()|.

BUG=578974
TEST=n/a; no behavior changes
==========

to

==========
This patch renames |editableRootElementForPosition()| to
|rootEditableElementOf()| to align with |Node::rootEditableElement() and
|VisiblePosition| version of |rootEditableElementOf()|.

BUG=578974
TEST=n/a; no behavior changes

Committed: https://crrev.com/d9a9181fd4f36031b9d02db8b82e1679a77844ea
Cr-Commit-Position: refs/heads/master@{#370679}
==========

[commit-bot: I haz the power, 2016-01-21 13:25:38]

Patchset 1 (id:??) landed as
https://crrev.com/d9a9181fd4f36031b9d02db8b82e1679a77844ea
Cr-Commit-Position: refs/heads/master@{#370679}

[tkent, 2016-01-26 04:23:59]

https://codereview.chromium.org/1611953002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/1611953002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:231: ContainerNode*
node = highestRoot->parentNode();
On 2016/01/21 at 13:19:38, tkent wrote:
> Not related to this CL, but I wonder why we need to scan ancestors of
rootEditableElement.

I realized this function could return a Document if BODY is missing.  Is this
intentional?

[yosin_UTC9, 2016-01-26 04:56:58]

On 2016/01/26 at 04:23:59, tkent wrote:
>
https://codereview.chromium.org/1611953002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):
> 
>
https://codereview.chromium.org/1611953002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/EditingUtilities.cpp:231:
ContainerNode* node = highestRoot->parentNode();
> On 2016/01/21 at 13:19:38, tkent wrote:
> > Not related to this CL, but I wonder why we need to scan ancestors of
rootEditableElement.
> 
> I realized this function could return a Document if BODY is missing.  Is this
intentional?

Because of its name, no |Element|, and return value |ContanerNode*|, it seems
|highestEditableRoot()| can return |Document|.

BTW, if we don't treat BODY as special, we can return |Document*| when
designMode is 'on'.