Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1611863002: Re-enable ContentViewPopupZoomerTest (Closed)

Created:
4 years, 11 months ago by trchen
Modified:
4 years, 11 months ago
Reviewers:
Ted C
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable ContentViewPopupZoomerTest PopupZoomer will stick to the initial container view and will refuse to switch when ContentViewCore.setContainerView() is invoked. This is by-design as we never intended to support disambiguation popup for WebView or fullscreen video. Removes @RerunWithUpdatedContainerView and re-enables the test. BUG=167045 Committed: https://crrev.com/d55838aa1e8e374819b78c6154991a2ca619d3cb Cr-Commit-Position: refs/heads/master@{#370782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/ContentViewPopupZoomerTest.java View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
trchen
4 years, 11 months ago (2016-01-21 02:35:13 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611863002/1
4 years, 11 months ago (2016-01-21 02:36:16 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-21 04:01:06 UTC) #6
Ted C
lgtm
4 years, 11 months ago (2016-01-21 17:47:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611863002/1
4 years, 11 months ago (2016-01-21 20:45:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 20:51:05 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 20:52:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d55838aa1e8e374819b78c6154991a2ca619d3cb
Cr-Commit-Position: refs/heads/master@{#370782}

Powered by Google App Engine
This is Rietveld 408576698