Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1611793003: X87: [compiler] Remove CodeStub from CompilationInfo. (Closed)

Created:
4 years, 11 months ago by zhengxing.li
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [compiler] Remove CodeStub from CompilationInfo. port d1d0196473e6919b222bf98a9fd9093805a5c5bc (r33410) original commit message: The motivation for this is that CompilationInfo really shouldn't explicitly know anything about CodeStubs. This is evident in the TurboFan stubs pipeline, which only needs to pass down information about Code::Flags to the code generator and not any of the CallInterfaceDescriptor silliness that Hydrogen has to push around, since TF has the Linkage class that encapsulates everything that is needed for the stub ABI. So, instead of threading CodeStub machinery through the TF stub pipeline, it is now removed from CompilationInfo and replaced by only the explicit bits needed both by the Crankshaft and TF pipelines in code generation. BUG= Committed: https://crrev.com/a2c0aee6284f62437964012d34f73832d9e3c760 Cr-Commit-Position: refs/heads/master@{#33423}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/crankshaft/x87/lithium-x87.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, Thanks!
4 years, 11 months ago (2016-01-21 03:10:38 UTC) #2
Weiliang
lgtm
4 years, 11 months ago (2016-01-21 03:24:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611793003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611793003/1
4 years, 11 months ago (2016-01-21 06:30:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 06:49:53 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 06:50:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2c0aee6284f62437964012d34f73832d9e3c760
Cr-Commit-Position: refs/heads/master@{#33423}

Powered by Google App Engine
This is Rietveld 408576698