Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

Issue 1611783002: Devtools Console: Tab to autocomplete and enter to execute command (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js b/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
index f882cfd0c4a168766a25165a7d0d426970e32f0e..cdb74ada0841ad74fd43fab9d765fbadab9573b8 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
@@ -286,7 +286,11 @@ WebInspector.TextPrompt.prototype = {
switch (event.keyIdentifier) {
case "U+0009": // Tab
- handled = this.tabKeyPressed(event);
+ // Accept autocomplete suggestion.
pfeldman 2016/01/22 01:09:08 Looked at the code. So you should leave this as is
samli 2016/01/22 01:17:27 Done - used acceptAutoComplete() instead since tha
+ if (this.isSuggestBoxVisible())
+ handled = this._suggestBox.enterKeyPressed();
+ else
+ handled = this.tabKeyPressed(event);
break;
case "Left":
case "Home":
@@ -318,7 +322,7 @@ WebInspector.TextPrompt.prototype = {
break;
}
- if (!handled && this.isSuggestBoxVisible())
+ if (!handled && this.isSuggestBoxVisible() && !isEnterKey(event))
pfeldman 2016/01/22 01:09:08 You should simply start onKeyDown with if (isEnte
samli 2016/01/22 01:17:27 Done.
handled = this._suggestBox.keyPressed(event);
if (!handled)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698