Devtools Console: Tab to autocomplete and enter to execute command

third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

Index: third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js b/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
index f882cfd0c4a168766a25165a7d0d426970e32f0e..4798c7af4444c365d7f2983a465513d215fcf25e 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
@@ -286,7 +286,9 @@ WebInspector.TextPrompt.prototype = {
 
         switch (event.keyIdentifier) {
         case "U+0009": // Tab
-            handled = this.tabKeyPressed(event);
+            // Accept autocomplete suggestion.
+            if (this.isSuggestBoxVisible())
+                handled = this._suggestBox.enterKeyPressed();

[pfeldman, 2016/01/21 19:23:38]

Do you want to dispatch tabKeyPressed otherwise?

[samli, 2016/01/21 23:03:47]

Yes, done.

             break;
         case "Left":
         case "Home":
@@ -318,7 +320,7 @@ WebInspector.TextPrompt.prototype = {
             break;
         }
 
-        if (!handled && this.isSuggestBoxVisible())
+        if (!handled && this.isSuggestBoxVisible() && event.keyIdentifier !== "Enter")

[pfeldman, 2016/01/21 19:23:38]

isEnterKey(event) is how we check for Enter. Why don't you let Enter in
suggestBox? I might need to poke around this code to figure out what it does. It
carries legacy :(

[samli, 2016/01/21 23:03:47]

Done. Allowing enter in suggest box will do the old behaviour, (accept first
suggestion in suggest box), then consume the event we have here, meaning it
won't propagate the event up to ConsoleView._promptKeyDown() where it handles
Enter key to execute command.

             handled = this._suggestBox.keyPressed(event);
 
         if (!handled)