Devtools Console: Tab to autocomplete and enter to execute command

third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

 /*
  * Copyright (C) 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 268 matching lines @@
     /**
      * @param {!Event} event
      */
     onKeyDown: function(event)
     {
         var handled = false;
         delete this._needUpdateAutocomplete;
 
         switch (event.keyIdentifier) {
         case "U+0009": // Tab
-            handled = this.tabKeyPressed(event);
+            // Accept autocomplete suggestion.

[pfeldman, 2016/01/22 01:09:08]

Looked at the code. So you should leave this as is, but in the tabKeyPressed,
you can replace the _completeCommonPrefix with the acceptSuggestion. That'll
replace present behavior with what you are aiming for.

[samli, 2016/01/22 01:17:27]

Done - used acceptAutoComplete() instead since that's what we want.

+            if (this.isSuggestBoxVisible())
+                handled = this._suggestBox.enterKeyPressed();
+            else
+                handled = this.tabKeyPressed(event);
             break;
         case "Left":
         case "Home":
             this._removeSuggestionAids();
             break;
         case "Right":

[pfeldman, 2016/01/22 01:21:20]

Or even better add Tab to the bunch and it'll do the same thing. Maybe we don't
even need the isCaret check because i could not make it trigger to false.

[samli, 2016/01/22 03:13:08]

StylesSidebarPane overrides tabKeyPressed(). Also able to trigger isCaretAtEnd()
check by typing then left, right keys.

         case "End":
             if (this.isCaretAtEndOfPrompt())
                 handled = this.acceptAutoComplete();
             else
                 this._removeSuggestionAids();
             break;
         case "U+001B": // Esc
             if (this.isSuggestBoxVisible()) {
                 this._removeSuggestionAids();
                 handled = true;
             }
             break;
         case "U+0020": // Space
             if (event.ctrlKey && !event.metaKey && !event.altKey && !event.shiftKey) {
                 this._updateAutoComplete(true);
                 handled = true;
             }
             break;
         case "Alt":
         case "Meta":
         case "Shift":
         case "Control":
             break;
         }
 
-        if (!handled && this.isSuggestBoxVisible())
+        if (!handled && this.isSuggestBoxVisible() && !isEnterKey(event))

[pfeldman, 2016/01/22 01:09:08]

You should simply start onKeyDown with

if (isEnterKey(event))
    return;

[samli, 2016/01/22 01:17:27]

Done.

             handled = this._suggestBox.keyPressed(event);
 
         if (!handled)
             this._needUpdateAutocomplete = true;
 
         if (handled)
             event.consume(true);
     },
 
     /**
@@ skipping 633 matching lines @@
 
             return;
         }
 
         WebInspector.TextPrompt.prototype.onKeyDown.apply(this, arguments);
     },
 
     __proto__: WebInspector.TextPrompt.prototype
 }