Devtools Console: Tab to autocomplete and enter to execute command

third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

 /*
  * Copyright (C) 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2011 Google Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 268 matching lines @@
     /**
      * @param {!Event} event
      */
     onKeyDown: function(event)
     {
         var handled = false;
         delete this._needUpdateAutocomplete;
 
         switch (event.keyIdentifier) {
         case "U+0009": // Tab
-            handled = this.tabKeyPressed(event);
+            // Accept autocomplete suggestion.
+            if (this.isSuggestBoxVisible())
+                handled = this._suggestBox.enterKeyPressed();

[pfeldman, 2016/01/21 19:23:38]

Do you want to dispatch tabKeyPressed otherwise?

[samli, 2016/01/21 23:03:47]

Yes, done.

             break;
         case "Left":
         case "Home":
             this._removeSuggestionAids();
             break;
         case "Right":
         case "End":
             if (this.isCaretAtEndOfPrompt())
                 handled = this.acceptAutoComplete();
             else
@@ skipping 11 matching lines @@
                 handled = true;
             }
             break;
         case "Alt":
         case "Meta":
         case "Shift":
         case "Control":
             break;
         }
 
-        if (!handled && this.isSuggestBoxVisible())
+        if (!handled && this.isSuggestBoxVisible() && event.keyIdentifier !== "Enter")

[pfeldman, 2016/01/21 19:23:38]

isEnterKey(event) is how we check for Enter. Why don't you let Enter in
suggestBox? I might need to poke around this code to figure out what it does. It
carries legacy :(

[samli, 2016/01/21 23:03:47]

Done. Allowing enter in suggest box will do the old behaviour, (accept first
suggestion in suggest box), then consume the event we have here, meaning it
won't propagate the event up to ConsoleView._promptKeyDown() where it handles
Enter key to execute command.

             handled = this._suggestBox.keyPressed(event);
 
         if (!handled)
             this._needUpdateAutocomplete = true;
 
         if (handled)
             event.consume(true);
     },
 
     /**
@@ skipping 633 matching lines @@
 
             return;
         }
 
         WebInspector.TextPrompt.prototype.onKeyDown.apply(this, arguments);
     },
 
     __proto__: WebInspector.TextPrompt.prototype
 }