Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1611753002: fixes #415, correct type for map literals (Closed)

Created:
4 years, 11 months ago by Jennifer Messerly
Modified:
4 years, 10 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org, Jacob
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fixes #415, correct type for map literals Not sure why this wasn't implemented. Lists seem to be okay. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/891627aee4a5ae0c12d8fdb9ca5e924429dfd7d2

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase on top of new runtime-in-dart #

Patch Set 3 : revert file add #

Patch Set 4 : add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -23 lines) Patch
M lib/runtime/dart/_runtime.js View 1 1 chunk +19 lines, -13 lines 0 comments Download
M lib/runtime/dart/convert.js View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/runtime/dart/html.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 2 chunks +7 lines, -3 lines 0 comments Download
M test/codegen/expect/collection/src/wrappers.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen/expect/language-all.js View 1 Binary file 0 comments Download
M tool/input_sdk/private/operations.dart View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Jennifer Messerly
4 years, 11 months ago (2016-01-20 23:31:20 UTC) #2
vsm
lgtm! https://codereview.chromium.org/1611753002/diff/1/lib/runtime/dart/_operations.js File lib/runtime/dart/_operations.js (right): https://codereview.chromium.org/1611753002/diff/1/lib/runtime/dart/_operations.js#newcode281 lib/runtime/dart/_operations.js:281: function map(values, K, V) { FWIW, dart.list is ...
4 years, 11 months ago (2016-01-20 23:39:34 UTC) #3
Jennifer Messerly
Thanks! https://codereview.chromium.org/1611753002/diff/1/lib/runtime/dart/_operations.js File lib/runtime/dart/_operations.js (right): https://codereview.chromium.org/1611753002/diff/1/lib/runtime/dart/_operations.js#newcode281 lib/runtime/dart/_operations.js:281: function map(values, K, V) { On 2016/01/20 23:39:33, ...
4 years, 10 months ago (2016-02-01 23:39:48 UTC) #5
Jennifer Messerly
4 years, 10 months ago (2016-02-01 23:39:58 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:80001) manually as
891627aee4a5ae0c12d8fdb9ca5e924429dfd7d2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698