Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1611743002: Fix extra clang tools build. (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
Reviewers:
danakj
CC:
chromium-reviews, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix extra clang tools build. BUG=none Committed: https://crrev.com/571e0cc7c5b7e8bc3c1fe84a26efb13fd8b47c27 Cr-Commit-Position: refs/heads/master@{#370766}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -19 lines) Patch
M tools/clang/pass_to_move/CMakeLists.txt View 1 chunk +1 line, -0 lines 1 comment Download
M tools/clang/rewrite_scoped_refptr/CMakeLists.txt View 1 chunk +1 line, -0 lines 0 comments Download
M tools/clang/rewrite_scoped_refptr/RewriteScopedRefptr.cpp View 8 chunks +19 lines, -19 lines 0 comments Download
M tools/clang/rewrite_to_chrome_style/CMakeLists.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dcheng
https://codereview.chromium.org/1611743002/diff/1/tools/clang/pass_to_move/CMakeLists.txt File tools/clang/pass_to_move/CMakeLists.txt (right): https://codereview.chromium.org/1611743002/diff/1/tools/clang/pass_to_move/CMakeLists.txt#newcode6 tools/clang/pass_to_move/CMakeLists.txt:6: X86CodeGen I'm not sure if this is still necessary ...
4 years, 11 months ago (2016-01-20 23:23:27 UTC) #3
danakj
LGTM
4 years, 11 months ago (2016-01-21 19:38:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611743002/1
4 years, 11 months ago (2016-01-21 19:40:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 20:13:58 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 20:15:34 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/571e0cc7c5b7e8bc3c1fe84a26efb13fd8b47c27
Cr-Commit-Position: refs/heads/master@{#370766}

Powered by Google App Engine
This is Rietveld 408576698