Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1611713002: Add Scroll Tree data structure (Closed)

Created:
4 years, 11 months ago by sunxd
Modified:
4 years, 11 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Scroll Tree data structure BUG=568830 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/4b67f3bb68e502f6d29dfe9b1e48f9070ae4714e Cr-Commit-Position: refs/heads/master@{#370705}

Patch Set 1 #

Patch Set 2 : Add scroll tree serialization unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -3 lines) Patch
M cc/proto/property_tree.proto View 4 chunks +14 lines, -3 lines 0 comments Download
M cc/trees/property_tree.h View 1 5 chunks +30 lines, -0 lines 0 comments Download
M cc/trees/property_tree.cc View 1 6 chunks +64 lines, -0 lines 0 comments Download
M cc/trees/property_tree_unittest.cc View 1 2 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sunxd
This only adds the data structure, most of the changes are still dead code now. ...
4 years, 11 months ago (2016-01-20 23:01:10 UTC) #3
jaydasika
lgtm
4 years, 11 months ago (2016-01-20 23:54:14 UTC) #4
ajuma
lgtm
4 years, 11 months ago (2016-01-21 15:10:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611713002/20001
4 years, 11 months ago (2016-01-21 15:12:35 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 15:56:55 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 15:58:36 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4b67f3bb68e502f6d29dfe9b1e48f9070ae4714e
Cr-Commit-Position: refs/heads/master@{#370705}

Powered by Google App Engine
This is Rietveld 408576698