Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: net/spdy/spdy_session.h

Issue 1611703003: Fix max_concurrent_streams == 0 behavior. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/spdy/spdy_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session.h
diff --git a/net/spdy/spdy_session.h b/net/spdy/spdy_session.h
index 5d72161b592ab84dfada78c0a20d1eb19969b67c..efab1b84433d7504b64ec033ae58fb33e9a7b5c7 100644
--- a/net/spdy/spdy_session.h
+++ b/net/spdy/spdy_session.h
@@ -535,6 +535,7 @@ class NET_EXPORT SpdySession : public BufferedSpdyFramerVisitorInterface,
FRIEND_TEST_ALL_PREFIXES(SpdySessionTest, SessionFlowControlNoSendLeaks);
FRIEND_TEST_ALL_PREFIXES(SpdySessionTest, SessionFlowControlEndToEnd);
FRIEND_TEST_ALL_PREFIXES(SpdySessionTest, StreamIdSpaceExhausted);
+ FRIEND_TEST_ALL_PREFIXES(SpdySessionTest, MaxConcurrentStreamsZero);
FRIEND_TEST_ALL_PREFIXES(SpdySessionTest, UnstallRacesWithStreamCreation);
FRIEND_TEST_ALL_PREFIXES(SpdySessionTest, GoAwayOnSessionFlowControlError);
FRIEND_TEST_ALL_PREFIXES(SpdySessionTest,
@@ -953,8 +954,6 @@ class NET_EXPORT SpdySession : public BufferedSpdyFramerVisitorInterface,
bool check_ping_status_pending() const { return check_ping_status_pending_; }
- size_t max_concurrent_streams() const { return max_concurrent_streams_; }
-
// Set whether priority->dependency conversion is enabled
// by default for all future SpdySessions.
static void SetPriorityDependencyDefaultForTesting(bool enable);
@@ -1069,7 +1068,7 @@ class NET_EXPORT SpdySession : public BufferedSpdyFramerVisitorInterface,
Error error_on_close_;
// Limits
- size_t max_concurrent_streams_; // 0 if no limit
+ size_t max_concurrent_streams_;
size_t max_concurrent_pushed_streams_;
// Some statistics counters for the session.
« no previous file with comments | « no previous file | net/spdy/spdy_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698