Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Issue 1611703003: Fix max_concurrent_streams == 0 behavior. (Closed)

Created:
4 years, 11 months ago by Bence
Modified:
4 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix max_concurrent_streams == 0 behavior. |max_concurrent_streams == 0| means no more stream can be created. It does not mean there is no limit on the number of streams. Also add regression test. I locally verified that the test fails without the fix. Also remove SpdySession::max_concurrent_streams() accessor that was only used in one place, in a test that is friends with SpdySession anyway so it can directly access the member in question. BUG=481009 Committed: https://crrev.com/16f6d4649cd3cc28a416c155dcde5c26eaddafb3 Cr-Commit-Position: refs/heads/master@{#370723}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -16 lines) Patch
M net/spdy/spdy_session.h View 3 chunks +2 lines, -3 lines 0 comments Download
M net/spdy/spdy_session.cc View 2 chunks +5 lines, -12 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 2 chunks +107 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 11 months ago (2016-01-21 14:20:39 UTC) #2
Ryan Hamilton
lgtm
4 years, 11 months ago (2016-01-21 14:52:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611703003/1
4 years, 11 months ago (2016-01-21 16:52:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 17:36:05 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 17:36:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/16f6d4649cd3cc28a416c155dcde5c26eaddafb3
Cr-Commit-Position: refs/heads/master@{#370723}

Powered by Google App Engine
This is Rietveld 408576698