Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1611663003: Revert of NaCl: Update revision in DEPS, 26c7e6a -> d8cbca8 (Closed)

Created:
4 years, 11 months ago by sgurun-gerrit only
Modified:
4 years, 11 months ago
CC:
chromium-reviews, erikchen, Roland McGrath, native-client-reviews_googlegroups.com, petarj, Sam Clegg, Jim Stichnoth, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of NaCl: Update revision in DEPS, 26c7e6a -> d8cbca8 (patchset #1 id:1 of https://codereview.chromium.org/1601743010/ ) Reason for revert: due to build break in https://build.chromium.org/p/chromium.win/waterfall?builder=Win%20x64%20Builder%20(dbg) Original issue's description: > NaCl: Update revision in DEPS, 26c7e6a -> d8cbca8 > > This pulls in the following Native Client changes: > > 95163bf: (stichnot@chromium.org) Update revision for PNaCl > abee7c9: (petarj@mips.com) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS > b44e8dc: (petarj@mips.com) [MIPS] Make $t8 point to the address of TLS pointers > 11ff949: (thakis@chromium.org) clang/win: Fix -Wsign-compare warning in platform_impl.cc > f39aa44: (mseaborn@chromium.org) PNaCl: Update llvm revision in pnacl/COMPONENT_REVISIONS: add ConvertToPSO > aebc3c4: (mcgrathr@chromium.org) Update chrome_rev > c4c237c: (erikchen@chromium.org) Back dynamic text regions with a Mach memory region. > 6c30fab: (sbc@chromium.org) untrusted.gypi: Remove support for old gcc newlib toolchain > dd69634: (stichnot@chromium.org) Subzero: Add pnacl-translate support for Subzero+NonSFI+x8632. > 2d5bba1: (dschuff@chromium.org) [PNaCl Toolchain] Use static libc++ from Chrome toolchain on Mac > bdd3ffa: (dschuff@chromium.org) Revert of [PNaCl Toolchain] Use static libc++ from Chrome toolchain on Mac (patchset #2 id:20001 of https://codereview.chromium.org/1586243003/ ) > a52204c: (dschuff@chromium.org) Revert of [PNaCl toolchain] Stop building and using custom libc++ for OSX hosts (patchset #2 id:20001 of https://codereview.chromium.org/1572753002/ ) > 7f31837: (dschuff@chromium.org) PNaCl toolchain: Add 'nostdinc++' to build of host tools against libc++ > d8cbca8: (dschuff@chromium.org) Update revision for PNaCl > > Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/26c7e6ae1327a43c948f4666fef9e84fe351ab7c..d8cbca85d544fd5d1469a8017bbf4d9136bfff5e > > BUG=none > TEST=browser_tests and nacl_integration > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build > > Committed: https://crrev.com/e5443f9b47b2474bebc8989b35b0182bfc191c89 > Cr-Commit-Position: refs/heads/master@{#370548} TBR=mseaborn@chromium.org,dschuff@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/38b5efd43f39caec997e343801e3ae712d4c67ad Cr-Commit-Position: refs/heads/master@{#370558}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sgurun-gerrit only
Created Revert of NaCl: Update revision in DEPS, 26c7e6a -> d8cbca8
4 years, 11 months ago (2016-01-21 01:26:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611663003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611663003/1
4 years, 11 months ago (2016-01-21 01:27:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 01:30:17 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 01:31:11 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38b5efd43f39caec997e343801e3ae712d4c67ad
Cr-Commit-Position: refs/heads/master@{#370558}

Powered by Google App Engine
This is Rietveld 408576698