Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1611633002: Remove SkLerpXfermode (Closed)

Created:
4 years, 11 months ago by robertphillips
Modified:
4 years, 11 months ago
Reviewers:
egdaniel, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove recent usages #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -226 lines) Patch
D gm/lerpmode.cpp View 1 chunk +0 lines, -42 lines 0 comments Download
M gyp/effects.gypi View 1 2 chunks +0 lines, -2 lines 0 comments Download
M include/core/SkScalar.h View 1 chunk +1 line, -1 line 0 comments Download
D include/effects/SkLerpXfermode.h View 1 1 chunk +0 lines, -47 lines 0 comments Download
M samplecode/SamplePathEffects.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkValue.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/SkArithmeticMode.cpp View 1 1 chunk +10 lines, -2 lines 0 comments Download
D src/effects/SkLerpXfermode.cpp View 1 1 chunk +0 lines, -118 lines 0 comments Download
M src/effects/SkToFromValue.cpp View 1 3 chunks +0 lines, -10 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
robertphillips
4 years, 11 months ago (2016-01-20 18:37:08 UTC) #4
reed1
WOOT lgtm
4 years, 11 months ago (2016-01-20 19:11:17 UTC) #5
mtklein
There aren't any .skps with SkLerpXfermodes in them, are there?
4 years, 11 months ago (2016-01-20 20:02:41 UTC) #7
robertphillips
From my understanding of where this was used in Chrome I don't believe SkLerpXfermodes should ...
4 years, 11 months ago (2016-01-25 21:52:09 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611633002/1
4 years, 11 months ago (2016-01-25 21:52:29 UTC) #10
mtklein
On 2016/01/25 21:52:29, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 11 months ago (2016-01-25 21:53:39 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac10.9-Clang-Arm7-Debug-iOS-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.9-Clang-Arm7-Debug-iOS-Trybot/builds/1013) Build-Ubuntu-Clang-x86_64-Debug-Trybot on ...
4 years, 11 months ago (2016-01-25 21:53:42 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611633002/20001
4 years, 11 months ago (2016-01-25 22:04:37 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-25 22:17:59 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611633002/20001
4 years, 11 months ago (2016-01-25 22:19:17 UTC) #20
commit-bot: I haz the power
4 years, 11 months ago (2016-01-25 22:20:01 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/64b0f5f95754c4d354d2e09cebf2a0c43d4cdd50

Powered by Google App Engine
This is Rietveld 408576698