Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 161163003: Update directions and lib paths for ninja. (Closed)

Created:
6 years, 10 months ago by jcgregorio
Modified:
6 years, 10 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Update directions and lib paths for ninja. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13429

Patch Set 1 #

Patch Set 2 : retry upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M experimental/SkV8Example/README View 1 chunk +1 line, -1 line 0 comments Download
M gyp/v8.gyp View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jcgregorio
6 years, 10 months ago (2014-02-12 21:19:18 UTC) #1
robertphillips
lgtm
6 years, 10 months ago (2014-02-12 23:10:20 UTC) #2
jcgregorio
The CQ bit was checked by jcgregorio@google.com
6 years, 10 months ago (2014-02-13 14:37:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jcgregorio@google.com/161163003/60001
6 years, 10 months ago (2014-02-13 14:37:52 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 15:30:09 UTC) #5
Message was sent while issue was closed. 
Change committed as 13429

Powered by Google App Engine
This is Rietveld 408576698