Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1611613002: [assembler] Remove obsolete InvokeBuiltin macro. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[assembler] Remove obsolete InvokeBuiltin macro. We no longer have the concept of "JS builtins" exposed to handwritten native code, so there's no need to keep the InvokeBuiltin macro around. R=mstarzinger@chromium.org Committed: https://crrev.com/801f1b6de81bc1629e6bf35642cfb5fafb15833e Cr-Commit-Position: refs/heads/master@{#33416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -129 lines) Patch
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 11 months ago (2016-01-20 18:29:37 UTC) #1
Benedikt Meurer
Hey Michi, Red-only CL. Dead code should be dead. Please take a look. Thanks, Benedikt
4 years, 11 months ago (2016-01-20 18:30:20 UTC) #2
Michael Starzinger
Instant-LGTM. Kill it with fire. :)
4 years, 11 months ago (2016-01-20 18:31:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611613002/1
4 years, 11 months ago (2016-01-20 18:55:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 19:19:19 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 19:19:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/801f1b6de81bc1629e6bf35642cfb5fafb15833e
Cr-Commit-Position: refs/heads/master@{#33416}

Powered by Google App Engine
This is Rietveld 408576698