Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 16116007: Give developers a correct command line to reproduce test failures without the use of selenium. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
===================================================================
--- tools/testing/dart/test_suite.dart (revision 23575)
+++ tools/testing/dart/test_suite.dart (working copy)
@@ -1010,7 +1010,15 @@
List<String> args = <String>[];
- if (TestUtils.usesWebDriver(runtime)) {
+ if (configuration['use_browser_controller']) {
+ // This command is not actually run, it is used for reproducing
+ // the failure.
+ args = ['tools/testing/dart/launch_browser.dart',
+ runtime,
+ fullHtmlPath];
+ commandSet.add(new Command(TestUtils.dartTestExecutable.toString(),
+ args));
+ } else if (TestUtils.usesWebDriver(runtime)) {
args = [
dartDir.append('tools/testing/run_selenium.py').toNativePath(),
'--browser=$runtime',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698