Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 16116003: Revert 202639 "Use totmaps if available on chromeos" (Closed)

Created:
7 years, 6 months ago by DaveMoore
Modified:
7 years, 6 months ago
Reviewers:
DaveMoore
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 202639 "Use totmaps if available on chromeos" > Use totmaps if available on chromeos > > We currently use statm on linux. This provides less than great results. > We take total resident memory and subtract "shared pages" from it instead of > using a count of pages that only this process has mapped. > > On chromeos we've added totmaps which sums up the fields from the process' > smaps. > > BUG=125150 > TEST=Examine memory reports from about:memory and task manager, and compare > them to the sums of the results in the smaps. > > R=thestig@chromium.org, willchan@chromium.org > > Review URL: https://codereview.chromium.org/15779007 TBR=davemoore@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202640 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202878

Patch Set 1 #

Patch Set 2 : Undo revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -38 lines) Patch
M base/process/process_metrics.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M base/process/process_metrics_linux.cc View 1 3 chunks +98 lines, -37 lines 0 comments Download
M chrome/browser/task_manager/task_manager.cc View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
DaveMoore
7 years, 6 months ago (2013-05-28 20:24:51 UTC) #1
DaveMoore
Committed patchset #1 manually as r202640.
7 years, 6 months ago (2013-05-28 20:25:00 UTC) #2
DaveMoore
7 years, 6 months ago (2013-05-29 15:42:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r202878.

Powered by Google App Engine
This is Rietveld 408576698