Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 16116002: MIPS: Fix the hole loading optimization. (Closed)

Created:
7 years, 7 months ago by palfia
Modified:
7 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Fix the hole loading optimization. Port r14829 (8fba0f34) Original commit message: Fix the hole loading optimization. - Holes are only ever loaded as double or tagged. - Change to tagged has to deoptimize on undefined (no implicit conversions from double the hole NaN -> tagged undefined). BUG= Committed: https://code.google.com/p/v8/source/detail?r=14831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -23 lines) Patch
M src/mips/lithium-codegen-mips.cc View 4 chunks +16 lines, -23 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
7 years, 7 months ago (2013-05-27 22:56:39 UTC) #1
Paul Lind
lgtm
7 years, 7 months ago (2013-05-27 23:01:07 UTC) #2
palfia
7 years, 7 months ago (2013-05-27 23:02:34 UTC) #3
Message was sent while issue was closed.
Committed manually as r14831 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698