third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp - Issue 1611523002: Require the entry document to have the same origin as the open()d document

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp

Issue 1611523002: Require the entry document to have the same origin as the open()d document (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt ('K') | « third_party/WebKit/LayoutTests/http/tests/security/aboutBlank/security-context-grandchildren-writeln-lexical-expected.txt ('k') | third_party/WebKit/Source/core/dom/Document.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp

index d600d096eb5a7886b7ef081fab6e792f19c72530..78066bf15ce539d8c80c7be27ad1ae382eef2361 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp

@@ -85,7 +85,7 @@ void V8Document::openMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& inf

}

ExceptionState exceptionState(ExceptionState::ExecutionContext, "open", "Document", info.Holder(), info.GetIsolate());

- document->open(callingDOMWindow(info.GetIsolate())->document(), exceptionState);

+ document->open(enteredDOMWindow(info.GetIsolate())->document(), exceptionState);

if (exceptionState.throwIfNeeded())

return;