third_party/WebKit/Source/core/dom/Document.h - Issue 1611523002: Require the entry document to have the same origin as the open()d document

Unified Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 1611523002: Require the entry document to have the same origin as the open()d document (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/security/aboutBlank/security-context-grandchildren-lexical-expected.txt ('K') | « third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp ('k') | third_party/WebKit/Source/core/dom/Document.cpp » ('j') | third_party/WebKit/Source/core/dom/Document.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Document.h

diff --git a/third_party/WebKit/Source/core/dom/Document.h b/third_party/WebKit/Source/core/dom/Document.h

index 060ec05cff53e2ed0c51521d98d207a4654ca649..ac19e961b9ae0e06ecc825f6151730f8ff71fb0f 100644

--- a/third_party/WebKit/Source/core/dom/Document.h

+++ b/third_party/WebKit/Source/core/dom/Document.h

@@ -473,7 +473,7 @@ public:

DocumentLoader* loader() const;

// This is the DOM API document.open()

- void open(Document* ownerDocument, ExceptionState&);

+ void open(Document* enteredDocument, ExceptionState&);

philipj_slow 2016/01/29 08:39:18 Can you document what the enteredDocument is? The

jochen (gone - plz use gerrit) 2016/01/29 09:40:24 added a comment.

// This is used internally and does not handle exceptions.

void open();

PassRefPtrWillBeRawPtr<DocumentParser> implicitOpen(ParserSynchronizationPolicy);

@@ -498,9 +498,9 @@ public:

void cancelParsing();

- void write(const SegmentedString& text, Document* ownerDocument = nullptr, ExceptionState& = ASSERT_NO_EXCEPTION);

- void write(const String& text, Document* ownerDocument = nullptr, ExceptionState& = ASSERT_NO_EXCEPTION);

- void writeln(const String& text, Document* ownerDocument = nullptr, ExceptionState& = ASSERT_NO_EXCEPTION);

+ void write(const SegmentedString& text, Document* enteredDocument = nullptr, ExceptionState& = ASSERT_NO_EXCEPTION);

+ void write(const String& text, Document* enteredDocument = nullptr, ExceptionState& = ASSERT_NO_EXCEPTION);

+ void writeln(const String& text, Document* enteredDocument = nullptr, ExceptionState& = ASSERT_NO_EXCEPTION);

void write(LocalDOMWindow*, const Vector<String>& text, ExceptionState&);

void writeln(LocalDOMWindow*, const Vector<String>& text, ExceptionState&);