Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1611513003: [wasm] Implemented F32Trunc as a turbofan graph based on int32 instructions. (Closed)

Created:
4 years, 11 months ago by ahaas
Modified:
4 years, 11 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Implemented F32Trunc as a turbofan graph based on int32 instructions. Platforms which do not provide rounding instructions (like x64 without sse4.1, arm before v8) fall back to this new soft float inplementation. BUG=575379 LOG=Y R=titzer@chromium.org Committed: https://crrev.com/a910cb4006ed52ff5f740a925f64578fafb7ba43 Cr-Commit-Position: refs/heads/master@{#33412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -11 lines) Patch
M src/compiler/wasm-compiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 2 chunks +69 lines, -3 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ahaas
4 years, 11 months ago (2016-01-20 13:37:00 UTC) #1
titzer
lgtm
4 years, 11 months ago (2016-01-20 15:28:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611513003/1
4 years, 11 months ago (2016-01-20 15:33:36 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9964)
4 years, 11 months ago (2016-01-20 15:35:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611513003/1
4 years, 11 months ago (2016-01-20 15:41:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 15:43:07 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 15:43:23 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a910cb4006ed52ff5f740a925f64578fafb7ba43
Cr-Commit-Position: refs/heads/master@{#33412}

Powered by Google App Engine
This is Rietveld 408576698