Remove the close button in context menu for IME menu.

chrome/common/extensions/extension_constants.h

Index: chrome/common/extensions/extension_constants.h
diff --git a/chrome/common/extensions/extension_constants.h b/chrome/common/extensions/extension_constants.h
index 090e2300a813591fd631f7641d19188dad79a32a..f3faa597844814d1ef7e78c31b06ec38ade82751 100644
--- a/chrome/common/extensions/extension_constants.h
+++ b/chrome/common/extensions/extension_constants.h
@@ -221,6 +221,11 @@ extern const char kWallpaperManagerId[];
 extern const char kWebstoreWidgetAppId[];
 // The extension id of the new ZIP unpacker extension.
 extern const char kZIPUnpackerExtensionId[];
+// The extension id of the IME extensions that will create IME menu.
+extern const char* const kImeMenuExtensionIds[2];

[stevenjb, 2016/01/28 18:45:04]

No need to expose the constants in the header if the helper function is defined
here.

+// Returns true if |extension_id| is one of the IME extensions that will create
+// IME menu.
+bool IsImeMenuExtensionId(const std::string extension_id);

[stevenjb, 2016/01/28 18:45:04]

Move this after constant definitions (and maybe to a different file - devlin,
WDYT?)

[Devlin, 2016/01/28 18:56:59]

I'd just get rid of this function since it's only used in once place.  If it's
used in more places in the future, yeah, it should go in some IME-related file
most likely.

[stevenjb, 2016/01/28 19:28:42]

Heh, so, I actually recommended that we not embed this logic in the place where
it is getting used (launcher_context_menu.cc, which, imho, should know as little
as possible about the details of what defines an ImeMenuExtension).

I could be convinced to go ahead and embed it there if you don't want it here.

[Devlin, 2016/01/28 19:39:00]

haha oh.  I agree that the ids shouldn't necessarily go there, but the function
here is just messing with my sense of symmetry.

If you don't even want the "if (id == ImeIds[0] || id == ImeIds[1])" in there,
then I don't feel really strongly, and it can stay here (underneath the other
constant declarations, as you said).

[stevenjb, 2016/01/28 19:46:17]

OK, let's go with that then (leaving the helper function in this C++ file,
removing the new constant from the header, and moving the function declaration
and implementation below the constants).

[Azure Wei, 2016/01/29 02:43:59]

Done. Thanks for all your comments.

 #endif
 
 // What causes an extension to be installed? Used in histograms, so don't