Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Unified Diff: chrome/browser/ui/ash/launcher/launcher_context_menu.cc

Issue 1611463002: Remove the close button in context menu for IME menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Steven's comments. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/launcher_context_menu.cc
diff --git a/chrome/browser/ui/ash/launcher/launcher_context_menu.cc b/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
index b72aab12ab06d3374ed5ee12ac00b92f1f8737a5..9465491489f9d04b2a5072c80d4d785af3d3aaf9 100644
--- a/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
+++ b/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
@@ -150,7 +150,14 @@ void LauncherContextMenu::Init() {
MENU_PIN,
l10n_util::GetStringUTF16(IDS_LAUNCHER_CONTEXT_MENU_PIN));
}
- if (controller_->IsOpen(item_.id)) {
+ bool show_close_button = controller_->IsOpen(item_.id);
+#if defined(OS_CHROMEOS)
+ if (extension_misc::IsImeMenuExtensionId(
+ controller_->GetAppIDForShelfID(item_.id))) {
+ show_close_button = false;
+ }
+#endif
+ if (show_close_button) {
AddItem(MENU_CLOSE,
l10n_util::GetStringUTF16(IDS_LAUNCHER_CONTEXT_MENU_CLOSE));
}
« no previous file with comments | « no previous file | chrome/common/extensions/extension_constants.h » ('j') | chrome/common/extensions/extension_constants.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698