Remove the close button in context menu for IME menu.

chrome/browser/ui/ash/launcher/launcher_context_menu.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/ash/launcher/launcher_context_menu.h"
 
 #include <string>
 
 #include "ash/desktop_background/user_wallpaper_delegate.h"
 #include "ash/metrics/user_metrics_recorder.h"
@@ skipping 133 matching lines @@
     } else if (item_.type == ash::TYPE_DIALOG) {
       AddItem(MENU_CLOSE,
               l10n_util::GetStringUTF16(IDS_LAUNCHER_CONTEXT_MENU_CLOSE));
     } else {
       if (item_.type == ash::TYPE_PLATFORM_APP) {
         AddItem(
             MENU_PIN,
             l10n_util::GetStringUTF16(IDS_LAUNCHER_CONTEXT_MENU_PIN));
       }
       if (controller_->IsOpen(item_.id)) {
-        AddItem(MENU_CLOSE,
-                l10n_util::GetStringUTF16(IDS_LAUNCHER_CONTEXT_MENU_CLOSE));
+        bool add_close_item = true;
+#if defined(OS_CHROMEOS)

[stevenjb, 2016/01/20 18:03:29]

Is there any reason why this needs to be OS_CHROMEOS only?

[Azure Wei, 2016/01/21 04:44:54]

The IME menu extensions are for Chrome OS only, so I put the definition of
kImeMenuExtensionIds[] under #if defined(OS_CHROMEOS) section. 

+        // Remove the close item of IME menu in the IME extensions.
+        for (const char* id : extension_misc::kIMEExtensionIds) {
+          if (controller_->GetAppIDForShelfID(item_.id) == id) {
+            add_close_item = false;
+          }
+        }

[stevenjb, 2016/01/20 18:03:29]

This logic really shouldn't be here. We should create a helper method, e.g.
extension_misc::isIMEExtension(id)

[Azure Wei, 2016/01/21 04:44:54]

Done.

+#endif
+        if (add_close_item) {
+          AddItem(MENU_CLOSE,
+                  l10n_util::GetStringUTF16(IDS_LAUNCHER_CONTEXT_MENU_CLOSE));
+        }
       }
     }
     AddSeparator(ui::NORMAL_SEPARATOR);
     if (item_.type == ash::TYPE_APP_SHORTCUT ||
         item_.type == ash::TYPE_WINDOWED_APP ||
         item_.type == ash::TYPE_PLATFORM_APP) {
       const extensions::MenuItem::ExtensionKey app_key(
           controller_->GetAppIDForShelfID(item_.id));
       if (!app_key.empty()) {
         int index = 0;
@@ skipping 164 matching lines @@
     case MENU_CHANGE_WALLPAPER:
       ash::Shell::GetInstance()->user_wallpaper_delegate()->
           OpenSetWallpaperPage();
       break;
 #endif
     default:
       extension_items_->ExecuteCommand(command_id, NULL,
                                        content::ContextMenuParams());
   }
 }