Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: content/renderer/bluetooth/bluetooth_dispatcher.cc

Issue 1611443002: bluetooth: Update BluetoothGATTCharacteristic.value on writeValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@useDataview
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/bluetooth/bluetooth_dispatcher.cc
diff --git a/content/renderer/bluetooth/bluetooth_dispatcher.cc b/content/renderer/bluetooth/bluetooth_dispatcher.cc
index 82bad22cb0993b98088c0f0bcf98e5f4d63f24cb..1e38a4099eb9d81458fc1139f8bfd04f4cfbf1b6 100644
--- a/content/renderer/bluetooth/bluetooth_dispatcher.cc
+++ b/content/renderer/bluetooth/bluetooth_dispatcher.cc
@@ -663,10 +663,13 @@ void BluetoothDispatcher::OnReadValueError(int thread_id,
pending_read_value_requests_.Remove(request_id);
}
-void BluetoothDispatcher::OnWriteValueSuccess(int thread_id, int request_id) {
+void BluetoothDispatcher::OnWriteValueSuccess(
+ int thread_id,
+ int request_id,
+ const std::vector<uint8_t>& value) {
ortuno 2016/01/20 16:34:40 I don't think you need to send back the value. You
DCHECK(pending_write_value_requests_.Lookup(request_id)) << request_id;
- pending_write_value_requests_.Lookup(request_id)->onSuccess();
+ pending_write_value_requests_.Lookup(request_id)->onSuccess(value);
pending_write_value_requests_.Remove(request_id);
}
« no previous file with comments | « content/renderer/bluetooth/bluetooth_dispatcher.h ('k') | third_party/WebKit/LayoutTests/bluetooth/writeValue.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698