third_party/WebKit/LayoutTests/fast/table/split-table-section-before-anonymous-block-2.html - Issue 1611413007: Remove unnecessary anonymous blocks when splitting anonymous boxes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/table/split-table-section-before-anonymous-block-2.html

Issue 1611413007: Remove unnecessary anonymous blocks when splitting anonymous boxes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@568387-RemovePercentHeight

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/table/split-table-section-before-anonymous-block-2-expected.html » ('j') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	mstensho (USE GERRIT) 2016/01/28 20:45:14 These tests both pass without your code changes These tests both pass without your code changes too. rhogan 2016/01/30 12:38:57 Yes, I give up on making these non-layout-tree tes Show quoted text On 2016/01/28 at 20:45:14, mstensho wrote: > These tests both pass without your code changes too. Yes, I give up on making these non-layout-tree tests. We're testing the removal of an unnecessary layout object so the render tree is the appropriate test I think. (I tried a unit test and failed to get it to work.)
	2 <p>crbug.com/568387: Should not ASSERT and should not leave an unnecessary anony mous block around the two inline-blocks.</p>

	3 <div style="display:table-row-group;">

	4 <div></div>

	5 <div id="splitter" style="display:none;"></div>

	6 <div style="display:inline-block; width:75px; height:50%; background:blue;"> </div>

	7 <div style="display:inline-block; width:75px; height:50%; background:blue;"> </div>

	8 </div>

	9 <script>

	10 document.body.offsetTop;

	11 document.getElementById("splitter").style.display = "table-row";

	12 </script>

OLD	NEW