third_party/WebKit/Source/core/html/HTMLSlotElement.h - Issue 1611413005: Make HTMLSlotElement.distributedNodeNextTo&distributedNodePreviousTo faster

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLSlotElement.h

Issue 1611413005: Make HTMLSlotElement.distributedNodeNextTo&distributedNodePreviousTo faster (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up code Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/PerformanceTests/ShadowDOM/SlotDistibutedNextPrevious.html ('k') | third_party/WebKit/Source/core/html/HTMLSlotElement.cpp » ('j') | third_party/WebKit/Source/core/html/HTMLSlotElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLSlotElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLSlotElement.h b/third_party/WebKit/Source/core/html/HTMLSlotElement.h

index 90f2cca132fceb496c986a8e6726ffe65920f3d2..931573cb051845400c313e5f5d2547a71a9895e7 100644

--- a/third_party/WebKit/Source/core/html/HTMLSlotElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLSlotElement.h

@@ -50,7 +50,6 @@ public:

Node* firstDistributedNode() const { return m_distributedNodes.isEmpty() ? nullptr : m_distributedNodes.first().get(); }

Node* lastDistributedNode() const { return m_distributedNodes.isEmpty() ? nullptr : m_distributedNodes.last().get(); }

- // TODO(hayato): This takes O(N). Make it O(1) with node-to-index hash table.

Node* distributedNodeNextTo(const Node&) const;

Node* distributedNodePreviousTo(const Node&) const;

@@ -76,8 +75,8 @@ private:

void removedFrom(ContainerNode*) override;

WillBeHeapVector<RefPtrWillBeMember<Node>> m_assignedNodes;

- // TODO(hayato): Share code with DistributedNode class

WillBeHeapVector<RefPtrWillBeMember<Node>> m_distributedNodes;

+ WillBeHeapHashMap<RawPtrWillBeMember<const Node>, size_t> m_distributedIndices;

};

} // namespace blink