Add support for iOS application bundle to GN.

base/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # HOW TO WRITE CONDITIONALS IN THIS FILE
 # ======================================
 #
 # In many other places, one would write a conditional that expresses all the
 # cases when a source file is used or unused, and then either add or subtract
 # it from the sources list in that case
@@ skipping 1859 matching lines @@
     "//third_party/icu",
   ]
 
   # Some unittests depend on the ALLOCATOR_SHIM macro.
   configs += [ "//base/allocator:allocator_shim_define" ]
 
   data = [
     "test/data/",
   ]
 
+  if (is_ios) {
+    bundle_test_name = "baseunittests"

[Dirk Pranke, 2016/01/29 00:54:25]

are underscores not allowed in the application ids ?

[sdefresne, 2016/02/05 10:20:00]

They are, but when using gyp, //testing/gtest.gyp went to great length to remove
the underscores from the target name
(https://code.google.com/p/chromium/codesearch#chromium/src/testing/gtest.gyp&...):

                'xcode_settings': {
                  'BUNDLE_ID_TEST_NAME':
                    '>!(echo ">(_target_name)" | sed -e "s/_//g")',
                  'INFOPLIST_FILE': '>(ios_unittest_info_plist_path)',
                },

[Dirk Pranke, 2016/02/10 01:18:13]

Okay. We should probably preserve compatibility, then, but I wonder why they did
that ...

+    test_data_files = [

[Dirk Pranke, 2016/01/29 00:54:25]

I think having to specify *every* test file may end up making things hard to
maintain.

In GYP, and in the isolates, we specify whole directories. This has the downside
of implying that ninja (and GYP) can't know when it needs to rebuild targets for
CLs that only change (or add) test files, but it has the upside that the build
files are a lot easier to maintain.

From talking to stuartmorgan@ and maruel@, it sounds like this is rarely a
problem in practice (changes to test files are usually accompanied by changes to
source files), and so from talking to brettw@, I think we agreed that maybe we
should modify the copy code to support test_data_file items that are also
directories (as long as they end in "/" we would do a recursive copy).

That would make this CL simpler and also simplify your net_unittests and
components_unittests CLs significantly. WDYT?

[sdefresne, 2016/02/05 10:20:00]

I agree that not listing all the files would make the CL simpler, however,
"copy" targets error out if the find directories in their "sources" argument
(they are of type SourceFile which raise an error if the path ends up with a
"/", see
https://code.google.com/p/chromium/codesearch#chromium/src/tools/gn/source_di...).

This means that I cannot just use "data" as the value of "sources" for the
"copy" target (as it contains "test/data/"). I can add a second variable
"test_data_files" that just contains "test/data", but then it is strange to not
have a trailing slash here, and to duplicate the same information).

[Dirk Pranke, 2016/02/10 01:18:12]

True. Maybe we should modify copy() to allow a recurse=True third parameter, or
add a copy_recursive function or something.

+      "test/data/file_util/binary_file.bin",
+      "test/data/file_util/binary_file_diff.bin",
+      "test/data/file_util/binary_file_same.bin",
+      "test/data/file_util/blank_line.txt",
+      "test/data/file_util/blank_line_crlf.txt",
+      "test/data/file_util/crlf.txt",
+      "test/data/file_util/different.txt",
+      "test/data/file_util/different_first.txt",
+      "test/data/file_util/different_last.txt",
+      "test/data/file_util/empty1.txt",
+      "test/data/file_util/empty2.txt",
+      "test/data/file_util/first1.txt",
+      "test/data/file_util/first2.txt",
+      "test/data/file_util/original.txt",
+      "test/data/file_util/red.png",
+      "test/data/file_util/same.txt",
+      "test/data/file_util/same_length.txt",
+      "test/data/file_util/shortened.txt",
+      "test/data/file_version_info_unittest/FileVersionInfoTest1.dll",
+      "test/data/file_version_info_unittest/FileVersionInfoTest2.dll",
+      "test/data/json/bom_feff.json",
+      "test/data/pe_image/pe_image_test_32.dll",
+      "test/data/pe_image/pe_image_test_64.dll",
+      "test/data/prefs/invalid.json",
+      "test/data/prefs/read.json",
+      "test/data/prefs/write.golden.json",
+      "test/data/serializer_nested_test.json",
+      "test/data/serializer_test.json",
+      "test/data/serializer_test_nowhitespace.json",
+    ]
+  }
+
   # Allow more direct string conversions on platforms with native utf8
   # strings
   if (is_mac || is_ios || is_chromeos) {
     defines = [ "SYSTEM_NATIVE_UTF8" ]
   }
 
   if (is_android) {
     deps += [
       ":base_java",
       ":base_java_unittest_support",
@@ skipping 248 matching lines @@
 
   # GYP: //base.gyp:base_java_unittest_support
   android_library("base_java_unittest_support") {
     deps = [
       ":base_java",
     ]
     java_files =
         [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ]
   }
 }