Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1611353003: tools/battor_agent: Stops BattOrAgent from being built on Android (Closed)

Created:
4 years, 11 months ago by charliea (OOO until 10-5)
Modified:
4 years, 11 months ago
Reviewers:
Dirk Pranke, dpranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

tools/battor_agent: Removes CrOS and Android from target platforms https://crrev.com/1611533002/ added necessary serial device enumeration to the agent, which broke the Android build because I was inadvertently building the agent on Android builders. My goal is to have battor_agent only be buildable on Mac, Windows, and Linux desktop machines. If I did that wrong, please let me know! Committed: https://crrev.com/00055282bebe9c692443d0bcb44fb4e9e008daeb Cr-Commit-Position: refs/heads/master@{#371367}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M build/gn_migration.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611353003/1
4 years, 11 months ago (2016-01-22 18:42:47 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/40036) linux_chromium_gn_chromeos_rel on ...
4 years, 11 months ago (2016-01-22 19:05:07 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611353003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611353003/40001
4 years, 11 months ago (2016-01-22 19:48:25 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-22 21:04:14 UTC) #8
charliea (OOO until 10-5)
4 years, 11 months ago (2016-01-25 21:25:05 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611353003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611353003/60001
4 years, 11 months ago (2016-01-25 21:27:33 UTC) #16
Dirk Pranke
lgtm
4 years, 11 months ago (2016-01-25 21:38:09 UTC) #18
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-25 22:57:20 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611353003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611353003/60001
4 years, 11 months ago (2016-01-26 00:01:17 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 11 months ago (2016-01-26 00:15:25 UTC) #23
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 00:18:31 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00055282bebe9c692443d0bcb44fb4e9e008daeb
Cr-Commit-Position: refs/heads/master@{#371367}

Powered by Google App Engine
This is Rietveld 408576698