|
|
Created:
4 years, 11 months ago by charliea (OOO until 10-5) Modified:
4 years, 11 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptiontools/battor_agent: Removes CrOS and Android from target platforms
https://crrev.com/1611533002/ added necessary serial device enumeration
to the agent, which broke the Android build because I was inadvertently
building the agent on Android builders.
My goal is to have battor_agent only be buildable on Mac, Windows, and
Linux desktop machines. If I did that wrong, please let me know!
Committed: https://crrev.com/00055282bebe9c692443d0bcb44fb4e9e008daeb
Cr-Commit-Position: refs/heads/master@{#371367}
Patch Set 1 : #Messages
Total messages: 25 (14 generated)
The CQ bit was checked by charliea@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611353003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611353003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by charliea@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611353003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611353003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Description was changed from ========== tools/battor_agent: Stops BattOrAgent from being built on Android https://crrev.com/1611533002/ added necessary serial device enumeration to the agent, which broke the Android build because I was inadvertently building the agent on Android builders. Given that the agent will be used from about:tracing, which is desktop-only, it makes sense to remove this from the Android builders. ========== to ========== tools/battor_agent: Removes CrOS and Android from target platforms https://crrev.com/1611533002/ added necessary serial device enumeration to the agent, which broke the Android build because I was inadvertently building the agent on Android builders. My goal is to have battor_agent only be buildable on Mac, Windows, and Linux desktop machines. If I did that wrong, please let me know! ==========
Patchset #1 (id:40001) has been deleted
charliea@chromium.org changed reviewers: + dpranke@google.com
The CQ bit was checked by charliea@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611353003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611353003/60001
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by charliea@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611353003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611353003/60001
Message was sent while issue was closed.
Committed patchset #1 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== tools/battor_agent: Removes CrOS and Android from target platforms https://crrev.com/1611533002/ added necessary serial device enumeration to the agent, which broke the Android build because I was inadvertently building the agent on Android builders. My goal is to have battor_agent only be buildable on Mac, Windows, and Linux desktop machines. If I did that wrong, please let me know! ========== to ========== tools/battor_agent: Removes CrOS and Android from target platforms https://crrev.com/1611533002/ added necessary serial device enumeration to the agent, which broke the Android build because I was inadvertently building the agent on Android builders. My goal is to have battor_agent only be buildable on Mac, Windows, and Linux desktop machines. If I did that wrong, please let me know! Committed: https://crrev.com/00055282bebe9c692443d0bcb44fb4e9e008daeb Cr-Commit-Position: refs/heads/master@{#371367} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/00055282bebe9c692443d0bcb44fb4e9e008daeb Cr-Commit-Position: refs/heads/master@{#371367} |