Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 161133004: Re-enable PrerenderBrowserTest.PrerenderRendererCrash. (Closed)

Created:
6 years, 10 months ago by davidben
Modified:
6 years, 10 months ago
Reviewers:
mmenke
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, davidben+watch_chromium.org
Visibility:
Public.

Description

Re-enable PrerenderBrowserTest.PrerenderRendererCrash. Tests have changed significantly since the flake. Hopefully all the base::RunLoop work has fixed it now. The stray content::RunMessageLoop is gone. BUG=171546 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250925

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/prerender/prerender_browsertest.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
davidben
Just re-enabling this one as-is. I suspect it's actually fine now.
6 years, 10 months ago (2014-02-12 20:57:27 UTC) #1
mmenke
On 2014/02/12 20:57:27, David Benjamin wrote: > Just re-enabling this one as-is. I suspect it's ...
6 years, 10 months ago (2014-02-12 21:00:57 UTC) #2
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 10 months ago (2014-02-12 21:01:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/161133004/1
6 years, 10 months ago (2014-02-12 21:04:33 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 03:48:51 UTC) #5
Message was sent while issue was closed.
Change committed as 250925

Powered by Google App Engine
This is Rietveld 408576698