third_party/instrumented_libraries/standard_instrumented_library_target.gypi - Issue 161133002: Don't depend on download_build_install.py in instrumented library targets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/instrumented_libraries/standard_instrumented_library_target.gypi

Issue 161133002: Don't depend on download_build_install.py in instrumented library targets. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comment it out Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/instrumented_libraries/standard_instrumented_library_target.gypi

diff --git a/third_party/instrumented_libraries/standard_instrumented_library_target.gypi b/third_party/instrumented_libraries/standard_instrumented_library_target.gypi

index 2bc2de20b4d0c4f5fe056737d79b7e43144af0f7..b1c5c49c480aa0e90be6aea3b5118c48d62d590f 100644

--- a/third_party/instrumented_libraries/standard_instrumented_library_target.gypi

+++ b/third_party/instrumented_libraries/standard_instrumented_library_target.gypi

@@ -12,7 +12,9 @@

{

'action_name': '<(_library_name)',

'inputs': [

- 'download_build_install.py',

+ # TODO(earthdok): reintroduce some sort of dependency

+ # See http://crbug.com/343515

+ #'download_build_install.py',

'outputs': [

'<(PRODUCT_DIR)/instrumented_libraries/<(_sanitizer_type)/<(_library_name).txt',

« no previous file with comments | « no previous file | no next file » | no next file with comments »