Treat bad values passed to --images as a fatal error

tools/flags/SkCommonFlags.h

Index: tools/flags/SkCommonFlags.h
diff --git a/tools/flags/SkCommonFlags.h b/tools/flags/SkCommonFlags.h
index ddd8d3a4a2f86022becfefcbdbad9f3fae604048..3a18c9f25a6a97d8c9c3e246cc4a91aa15e016e5 100644
--- a/tools/flags/SkCommonFlags.h
+++ b/tools/flags/SkCommonFlags.h
@@ -9,6 +9,8 @@
 #define SK_COMMON_FLAGS_H
 
 #include "SkCommandLineFlags.h"
+#include "SkTArray.h"
+#include "SkString.h"
 
 DECLARE_bool(cpu);
 DECLARE_bool(dryRun);
@@ -29,4 +31,19 @@ DECLARE_string(writePath);
 DECLARE_string(key);
 DECLARE_string(properties);
 
+namespace SkCommonFlags {

[mtklein, 2016/01/22 18:05:15]

I don't this needs a namespace or an SkPrefix.  We're not shipping this code as
part of Skia.

CollectImages is just fine.

[scroggo, 2016/01/27 15:43:36]

Done.

+    /**
+     *  Helper to assist in collecting images from --images.
+     *
+     *  Populates an input array of strings with paths to images to test.
+     *
+     *  If a directory is passed to --images that does not have any supported images (based on file
+     *  type), this will exit the program, so the user or bot can rerun using the correct directory.

[mtklein, 2016/01/22 18:05:15]

Let's have it return false rather than exiting.
It'd be a little more comforting to see the exit-on-failure explicitly written
out in each of DM/nanobench's main functions.

If that can't work, we'd better name this something like collectImagesOrDie().

[scroggo, 2016/01/27 15:43:36]

Done.

+     *
+     *  If a file is passed to --images, assume the user is deliberately testing this image,
+     *  regardless of file type.
+     */
+    void collectImages(SkTArray<SkString>*);
+}
+
 #endif