Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 1611323002: Temporarily comment out breaking scalefactor test expectations. (Closed)

Created:
4 years, 11 months ago by wkorman
Modified:
4 years, 11 months ago
Reviewers:
oshima
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily comment out breaking scalefactor test expectations. These expectations break the Blink auto-rebaseline bot. Disable them while we're debugging to unblock other rebaselines. BUG=577300, 495750 TBR=oshima Committed: https://chromium.googlesource.com/chromium/src/+/4ff9d8538064843279add0ba3a10b1d2fc778167

Patch Set 1 #

Patch Set 2 : Uncomment two skips. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +4 lines, -3 lines 1 comment Download

Messages

Total messages: 7 (4 generated)
wkorman
Committed patchset #2 (id:20001) manually as 4ff9d8538064843279add0ba3a10b1d2fc778167 (presubmit successful).
4 years, 11 months ago (2016-01-21 18:30:45 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4ff9d8538064843279add0ba3a10b1d2fc778167 Cr-Commit-Position: refs/heads/master@{#370732}
4 years, 11 months ago (2016-01-21 18:30:45 UTC) #5
oshima
4 years, 11 months ago (2016-01-21 18:34:14 UTC) #7
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/1611323002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/1611323002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/TestExpectations:239: crbug.com/495750
virtual/scalefactor200withzoom/fast/hidpi/static/data-suggestion-picker-appearance.html
[ Skip ]
Can these be causing a problem? I think we can remove this (although the
generate image may not be correct)

Powered by Google App Engine
This is Rietveld 408576698