Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: src/accessors.cc

Issue 1611313003: Revert of Array length reduction should throw in strict mode if it can't delete an element. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8.h ('k') | src/arguments.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/accessors.cc
diff --git a/src/accessors.cc b/src/accessors.cc
index 31139b79614aaecb47559a3928fd299071be3d26..502dc4c1b256e1027dd2cf8234534da35b38a89e 100644
--- a/src/accessors.cc
+++ b/src/accessors.cc
@@ -204,19 +204,6 @@
if (JSArray::ObservableSetLength(array, length).is_null()) {
isolate->OptionalRescheduleException(false);
}
-
- if (info.ShouldThrowOnError()) {
- uint32_t actual_new_len = 0;
- CHECK(array->length()->ToArrayLength(&actual_new_len));
- // Throw TypeError if there were non-deletable elements.
- if (actual_new_len != length) {
- Factory* factory = isolate->factory();
- isolate->Throw(*factory->NewTypeError(
- MessageTemplate::kStrictDeleteProperty,
- factory->NewNumberFromUint(actual_new_len - 1), array));
- isolate->OptionalRescheduleException(false);
- }
- }
}
@@ -1417,7 +1404,6 @@
static void ModuleSetExport(v8::Local<v8::Name> property,
v8::Local<v8::Value> value,
const v8::PropertyCallbackInfo<void>& info) {
- if (!info.ShouldThrowOnError()) return;
Handle<Name> name = v8::Utils::OpenHandle(*property);
Isolate* isolate = name->GetIsolate();
Handle<Object> exception =
« no previous file with comments | « include/v8.h ('k') | src/arguments.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698