Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: src/arguments.cc

Issue 1611313003: Revert of Array length reduction should throw in strict mode if it can't delete an element. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arguments.h ('k') | src/arm/code-stubs-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/arguments.h" 5 #include "src/arguments.h"
6 6
7 #include "src/api.h" 7 #include "src/api.h"
8 #include "src/vm-state-inl.h" 8 #include "src/vm-state-inl.h"
9 9
10 namespace v8 { 10 namespace v8 {
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 Function f, Arg1 arg1, Arg2 arg2) { \ 63 Function f, Arg1 arg1, Arg2 arg2) { \
64 Isolate* isolate = this->isolate(); \ 64 Isolate* isolate = this->isolate(); \
65 VMState<EXTERNAL> state(isolate); \ 65 VMState<EXTERNAL> state(isolate); \
66 ExternalCallbackScope call_scope(isolate, FUNCTION_ADDR(f)); \ 66 ExternalCallbackScope call_scope(isolate, FUNCTION_ADDR(f)); \
67 PropertyCallbackInfo<ReturnValue> info(begin()); \ 67 PropertyCallbackInfo<ReturnValue> info(begin()); \
68 f(arg1, arg2, info); \ 68 f(arg1, arg2, info); \
69 return GetReturnValue<ReturnValue>(isolate); \ 69 return GetReturnValue<ReturnValue>(isolate); \
70 } 70 }
71 71
72 72
73 #define WRITE_CALL_2_VOID(Function, ReturnValue, Arg1, Arg2) \ 73 #define WRITE_CALL_2_VOID(Function, ReturnValue, Arg1, Arg2) \
74 void PropertyCallbackArguments::Call(Function f, Arg1 arg1, Arg2 arg2) { \ 74 void PropertyCallbackArguments::Call(Function f, \
75 Isolate* isolate = this->isolate(); \ 75 Arg1 arg1, \
76 VMState<EXTERNAL> state(isolate); \ 76 Arg2 arg2) { \
77 ExternalCallbackScope call_scope(isolate, FUNCTION_ADDR(f)); \ 77 Isolate* isolate = this->isolate(); \
78 PropertyCallbackInfo<ReturnValue> info(begin()); \ 78 VMState<EXTERNAL> state(isolate); \
79 f(arg1, arg2, info); \ 79 ExternalCallbackScope call_scope(isolate, FUNCTION_ADDR(f)); \
80 } 80 PropertyCallbackInfo<ReturnValue> info(begin()); \
81 f(arg1, arg2, info); \
82 }
81 83
82 84
83 FOR_EACH_CALLBACK_TABLE_MAPPING_0(WRITE_CALL_0) 85 FOR_EACH_CALLBACK_TABLE_MAPPING_0(WRITE_CALL_0)
84 FOR_EACH_CALLBACK_TABLE_MAPPING_1(WRITE_CALL_1) 86 FOR_EACH_CALLBACK_TABLE_MAPPING_1(WRITE_CALL_1)
85 FOR_EACH_CALLBACK_TABLE_MAPPING_2(WRITE_CALL_2) 87 FOR_EACH_CALLBACK_TABLE_MAPPING_2(WRITE_CALL_2)
86 FOR_EACH_CALLBACK_TABLE_MAPPING_2_VOID_RETURN(WRITE_CALL_2_VOID) 88 FOR_EACH_CALLBACK_TABLE_MAPPING_2_VOID_RETURN(WRITE_CALL_2_VOID)
87 89
88 #undef WRITE_CALL_0 90 #undef WRITE_CALL_0
89 #undef WRITE_CALL_1 91 #undef WRITE_CALL_1
90 #undef WRITE_CALL_2 92 #undef WRITE_CALL_2
91 #undef WRITE_CALL_2_VOID 93 #undef WRITE_CALL_2_VOID
92 94
93 95
94 double ClobberDoubleRegisters(double x1, double x2, double x3, double x4) { 96 double ClobberDoubleRegisters(double x1, double x2, double x3, double x4) {
95 // TODO(ulan): This clobbers only subset of registers depending on compiler, 97 // TODO(ulan): This clobbers only subset of registers depending on compiler,
96 // Rewrite this in assembly to really clobber all registers. 98 // Rewrite this in assembly to really clobber all registers.
97 // GCC for ia32 uses the FPU and does not touch XMM registers. 99 // GCC for ia32 uses the FPU and does not touch XMM registers.
98 return x1 * 1.01 + x2 * 2.02 + x3 * 3.03 + x4 * 4.04; 100 return x1 * 1.01 + x2 * 2.02 + x3 * 3.03 + x4 * 4.04;
99 } 101 }
100 102
101 103
102 } // namespace internal 104 } // namespace internal
103 } // namespace v8 105 } // namespace v8
OLDNEW
« no previous file with comments | « src/arguments.h ('k') | src/arm/code-stubs-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698