Issue 1611293003: Add vcvt.s32.f32 instruction to the integrated ARM assembler.

Issue 1611293003: Add vcvt.s32.f32 instruction to the integrated ARM assembler. (Closed)

Created:
4 years, 11 months ago by Karl

Modified:
4 years, 11 months ago

Reviewers:
Jim Stichnoth, sehr, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add vcvt.s32.f32 instruction to the integrated ARM assembler. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334 R=jpp@chromium.org, stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=94cc3e6190b3b91d1ac6c4e894391d48228f8e97

Patch Set 3 : Fix not. #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -7 lines)			Patch
M	src/DartARM32/assembler_arm.h	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/DartARM32/assembler_arm.cc	View	1 2	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/IceAssemblerARM32.h	View	1 2	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/IceAssemblerARM32.cpp	View	1 2	2 chunks	+16 lines, -1 line	0 comments	Download
M	src/IceInstARM32.cpp	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
A	tests_lit/assembler/arm32/vcvt.s32.f32.ll	View	1 2	1 chunk	+38 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jim Stichnoth

lgtm https://codereview.chromium.org/1611293003/diff/20001/tests_lit/assembler/arm32/vcvt.s32.f32.ll File tests_lit/assembler/arm32/vcvt.s32.f32.ll (right): https://codereview.chromium.org/1611293003/diff/20001/tests_lit/assembler/arm32/vcvt.s32.f32.ll#newcode1 tests_lit/assembler/arm32/vcvt.s32.f32.ll:1: ; Show that we know how to translate ...

4 years, 11 months ago (2016-01-22 04:35:22 UTC) #5

Karl

Committed patchset #3 (id:40001) manually as 94cc3e6190b3b91d1ac6c4e894391d48228f8e97 (presubmit successful).

4 years, 11 months ago (2016-01-22 16:33:55 UTC) #7

Karl

4 years, 11 months ago (2016-01-22 16:40:39 UTC) #8

Message was sent while issue was closed.

https://codereview.chromium.org/1611293003/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/vcvt.s32.f32.ll (right):

https://codereview.chromium.org/1611293003/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/vcvt.s32.f32.ll:1: ; Show that we know how to
translate convertring float to signed integer.
On 2016/01/22 04:35:22, stichnot wrote:
> converting

Done.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages