Demo fuzz for Herb

Demo fuzz for Herb

BUG=skia:4692
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1611293002

Committed: https://skia.googlesource.com/skia/+/26379ca002f243efe2d799eeaab715b31137e62a

[mtklein_C, 2016-01-21 17:09:24]

Description was changed from

==========
Demo fuzz for Herb

BUG=skia:4692
==========

to

==========
Demo fuzz for Herb

BUG=skia:4692
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2016-01-21 17:10:23]

mtklein@chromium.org changed reviewers:
+ herb@google.com

[mtklein_C, 2016-01-21 17:10:23]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-01-21 17:10:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1611293002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1611293002/1

[commit-bot: I haz the power, 2016-01-21 17:10:28]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-01-21 23:10 UTC

[mtklein_C, 2016-01-21 17:13:19]

+kjlubick, FYI we have a customer

[herb_g, 2016-01-21 17:15:27]

lgtm

[kjlubick, 2016-01-21 17:17:52]

kjlubick@google.com changed reviewers:
+ kjlubick@google.com

[kjlubick, 2016-01-21 17:17:52]

https://codereview.chromium.org/1611293002/diff/1/fuzz/FuzzScaleToSides.cpp
File fuzz/FuzzScaleToSides.cpp (right):

https://codereview.chromium.org/1611293002/diff/1/fuzz/FuzzScaleToSides.cpp#n...
fuzz/FuzzScaleToSides.cpp:24: if (!std::isfinite(radius1) ||
Why not std::isnormal(), which accounts for infinite, NaN and zero?

[commit-bot: I haz the power, 2016-01-21 17:25:35]

Description was changed from

==========
Demo fuzz for Herb

BUG=skia:4692
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Demo fuzz for Herb

BUG=skia:4692
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/26379ca002f243efe2d799eeaab715b31137e62a
==========

[commit-bot: I haz the power, 2016-01-21 17:25:35]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/26379ca002f243efe2d799eeaab715b31137e62a

[mtklein, 2016-01-21 17:37:46]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-01-21 17:37:47]

https://codereview.chromium.org/1611293002/diff/1/fuzz/FuzzScaleToSides.cpp
File fuzz/FuzzScaleToSides.cpp (right):

https://codereview.chromium.org/1611293002/diff/1/fuzz/FuzzScaleToSides.cpp#n...
fuzz/FuzzScaleToSides.cpp:24: if (!std::isfinite(radius1) ||
On 2016/01/21 17:17:52, kjlubick wrote:
> Why not std::isnormal(), which accounts for infinite, NaN and zero?

Zeros and subnormals should work for some of these.

[herb_g, 2016-01-21 17:38:20]

https://codereview.chromium.org/1611293002/diff/1/fuzz/FuzzScaleToSides.cpp
File fuzz/FuzzScaleToSides.cpp (right):

https://codereview.chromium.org/1611293002/diff/1/fuzz/FuzzScaleToSides.cpp#n...
fuzz/FuzzScaleToSides.cpp:24: if (!std::isfinite(radius1) ||
On 2016/01/21 17:37:46, mtklein wrote:
> On 2016/01/21 17:17:52, kjlubick wrote:
> > Why not std::isnormal(), which accounts for infinite, NaN and zero?
> 
> Zeros and subnormals should work for some of these.

What he said.