Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1611193004: Catch runtime exception when creating MediaThrottler (Closed)

Created:
4 years, 11 months ago by qinmin
Modified:
4 years, 11 months ago
Reviewers:
Yaron
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Catch runtime exception when creating MediaThrottler MediaPlayer.create() can throw Runtime exception. Catch the exception to prevent app crash. BUG=579702 Committed: https://crrev.com/c4a11e8be4fd16ec51ee3a5efcc22e57043b3475 Cr-Commit-Position: refs/heads/master@{#370783}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/MediaThrottler.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
qinmin
PTAL
4 years, 11 months ago (2016-01-21 18:42:50 UTC) #2
Yaron
lgtm
4 years, 11 months ago (2016-01-21 19:05:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1611193004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1611193004/1
4 years, 11 months ago (2016-01-21 19:08:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 20:51:21 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 20:52:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4a11e8be4fd16ec51ee3a5efcc22e57043b3475
Cr-Commit-Position: refs/heads/master@{#370783}

Powered by Google App Engine
This is Rietveld 408576698