content/renderer/render_frame_impl.h - Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index 129dfc72066d4f43ac37d80dfdfd435594fc0b69..66803ce791fcf6343b5426f9520acdf33d65e55e 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -101,6 +101,8 @@ class CONTENT_EXPORT RenderFrameImpl

// TODO(nasko): Those are page-level methods at this time and come from

// WebViewClient. We should move them to be WebFrameClient calls and put

// logic in the browser side to balance starts/stops.

+ // |to_different_document| will be true unless the load is a fragment

+ // navigation, or triggered by history.pushState/replaceState.

virtual void didStartLoading(bool to_different_document);

virtual void didStopLoading();

virtual void didChangeLoadProgress(double load_progress);