content/browser/web_contents/web_contents_impl.h - Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index e6135d1db216fd96784603ac9e28d62291bd11da..ae72bdf1e237eb5278e6695d6a1598ae75027a4f 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -304,7 +304,8 @@ class CONTENT_EXPORT WebContentsImpl

const IPC::Message& message) OVERRIDE;

virtual void RenderFrameCreated(RenderFrameHost* render_frame_host) OVERRIDE;

virtual void RenderFrameDeleted(RenderFrameHost* render_frame_host) OVERRIDE;

- virtual void DidStartLoading(RenderFrameHost* render_frame_host) OVERRIDE;

+ virtual void DidStartLoading(RenderFrameHost* render_frame_host,

+ bool to_different_document) OVERRIDE;

virtual void DidStopLoading(RenderFrameHost* render_frame_host) OVERRIDE;

virtual void WorkerCrashed(RenderFrameHost* render_frame_host) OVERRIDE;

virtual void ShowContextMenu(RenderFrameHost* render_frame_host,

@@ -589,6 +590,7 @@ class CONTENT_EXPORT WebContentsImpl

// (but can be null if not applicable).

virtual void SetIsLoading(RenderViewHost* render_view_host,

bool is_loading,

+ bool to_different_document,

LoadNotificationDetails* details) OVERRIDE;

typedef base::Callback<void(WebContents*)> CreatedCallback;