components/web_contents_delegate_android/web_contents_delegate_android.cc - Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_contents_delegate_android/web_contents_delegate_android.cc

Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/web_contents_delegate_android/web_contents_delegate_android.h ('k') | content/browser/frame_host/interstitial_page_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_contents_delegate_android/web_contents_delegate_android.cc

diff --git a/components/web_contents_delegate_android/web_contents_delegate_android.cc b/components/web_contents_delegate_android/web_contents_delegate_android.cc

index d12a23f665cd09de17271ba0f92d9045bc66b964..a4f8213bfbe030c2e8955053d6111a1c599572ce 100644

--- a/components/web_contents_delegate_android/web_contents_delegate_android.cc

+++ b/components/web_contents_delegate_android/web_contents_delegate_android.cc

@@ -139,7 +139,8 @@ void WebContentsDelegateAndroid::DeactivateContents(WebContents* contents) {

// to focus. Not implemented on Android.

}

-void WebContentsDelegateAndroid::LoadingStateChanged(WebContents* source) {

+void WebContentsDelegateAndroid::LoadingStateChanged(WebContents* source,

+ bool to_different_document) {

JNIEnv* env = AttachCurrentThread();

ScopedJavaLocalRef<jobject> obj = GetJavaDelegate(env);

if (obj.is_null())