chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc - Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc

Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/panels/panel_host.cc ('k') | components/web_contents_delegate_android/web_contents_delegate_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc

diff --git a/chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc b/chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc

index 2caef65cdb57239f695adf233960cdb62caa7c32..767db59cbfe7ee0676fe17e25fedbfbc75eae348 100644

--- a/chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc

+++ b/chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc

@@ -69,7 +69,7 @@ TEST_F(WebDialogWebContentsDelegateTest, DoNothingMethodsTest) {

content::PAGE_TRANSITION_TYPED, history::SOURCE_SYNCED, false);

test_web_contents_delegate_->NavigationStateChanged(NULL, 0);

test_web_contents_delegate_->ActivateContents(NULL);

- test_web_contents_delegate_->LoadingStateChanged(NULL);

+ test_web_contents_delegate_->LoadingStateChanged(NULL, true);

test_web_contents_delegate_->CloseContents(NULL);

test_web_contents_delegate_->UpdateTargetURL(NULL, 0, GURL());

test_web_contents_delegate_->MoveContents(NULL, gfx::Rect());

« no previous file with comments | « chrome/browser/ui/panels/panel_host.cc ('k') | components/web_contents_delegate_android/web_contents_delegate_android.h » ('j') | no next file with comments »