chrome/browser/android/chrome_web_contents_delegate_android.cc - Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/chrome_web_contents_delegate_android.cc

Issue 161113002: Fix pushState causing stop/reload button and favicon to flicker. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/chrome_web_contents_delegate_android.cc

diff --git a/chrome/browser/android/chrome_web_contents_delegate_android.cc b/chrome/browser/android/chrome_web_contents_delegate_android.cc

index 3f6aa0e530c02820964c685c930475b4ca908b66..a5c2e8c41b964dc8b88fae7688515324b90fc872 100644

--- a/chrome/browser/android/chrome_web_contents_delegate_android.cc

+++ b/chrome/browser/android/chrome_web_contents_delegate_android.cc

@@ -88,9 +88,10 @@ bool RegisterChromeWebContentsDelegateAndroid(JNIEnv* env) {

}

void ChromeWebContentsDelegateAndroid::LoadingStateChanged(

- WebContents* source) {

+ WebContents* source, bool to_different_document) {

bool has_stopped = source == NULL || !source->IsLoading();

- WebContentsDelegateAndroid::LoadingStateChanged(source);

+ WebContentsDelegateAndroid::LoadingStateChanged(

+ source, to_different_document);

LoadProgressChanged(source, has_stopped ? 1 : 0);

}